[Refactor] Phase out python dependency attrs#17649
Merged
tqchen merged 3 commits intoapache:mainfrom Feb 13, 2025
Merged
Conversation
- Remove attrs from base requirements and constraints - Replace attr.s decorator with @DataClass in memory_plan.py - Simplify Region class definition using dataclass
- Remove attrs from conda recipe requirements - Remove attrs from Docker installation scripts for Ubuntu - Update documentation to remove attrs from pip install instructions
tqchen
approved these changes
Feb 13, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* Remove attrs dependency and migrate to dataclasses - Remove attrs from base requirements and constraints - Replace attr.s decorator with @DataClass in memory_plan.py - Simplify Region class definition using dataclass * Remove attrs dependency from installation scripts and documentation - Remove attrs from conda recipe requirements - Remove attrs from Docker installation scripts for Ubuntu - Update documentation to remove attrs from pip install instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at removing the
attrslibrary and replacing its usage with a python 3.7+ builtindataclassesin the codebase. Additionally, it updates various dependency lists and installation scripts to reflect this removal.Code refactoring:
python/tvm/relay/transform/memory_plan.py: Replacedattr.swithdataclassfor defining theRegionclass. [1] [2]Dependency updates:
conda/recipe/meta.yaml: Removedattrsfrom the list of dependencies.docker/install/ubuntu2004_install_python_package.sh: Removedattrsfrom the list of Python packages to be installed.docker/install/ubuntu_install_python_package.sh: Removedattrsfrom the list of Python packages to be installed.docs/install/from_source.rst: Removedattrsfrom the example command for installing extra Python dependencies.python/gen_requirements.py: Removedattrsfrom the base requirements and constraints. [1] [2]